On Thu, Apr 23, 2026 at 4:34 PM Josh Poimboeuf <[email protected]> wrote: > > On Thu, Apr 23, 2026 at 11:54:39AM -0700, Song Liu wrote: > > On Wed, Apr 22, 2026 at 9:04 PM Josh Poimboeuf <[email protected]> wrote: > > > > > > While there was once a section named .data.once, it has since been > > > renamed to .data..once with commit dbefa1f31a91 ("Rename .data.once to > > > .data..once to fix resetting WARN*_ONCE"). Fix it. > > > > > > Fixes: dd590d4d57eb ("objtool/klp: Introduce klp diff subcommand for > > > diffing object files") > > > Signed-off-by: Josh Poimboeuf <[email protected]> > > > > Acked-by: Song Liu <[email protected]> > > > > Nitpick: shall we match both ".data.once" and ".data..once", so that whoever > > backports klp-build to older kernels will not have a surprise. > > Hm, I'm a bit hesitant to do that. One of the nice things about having > this code upstream is that we don't have to start collecting all the > cruft for old kernels.
Agreed. Instead of matching both, we can probably cover this with a test case. Thanks, Song
