On 4/30/26 00:20, Jürgen Groß wrote:
> On 29.04.26 20:45, Dave Hansen wrote:
>> From: Dave Hansen <[email protected]>
>>
>> errno.h is already included for C code at the top of the header.
>
> I'm seeing only asm/errno.h being included.
>
> I don't say linux/errno.h is needed, but the reasoning is not really
> convincing.
Yes, completely agree. I goofed that one was linux/errno.h and the other
was asm/errno.h. So the reasoning was bogus. But I do think it's still a
good idea for other reasons. How about:
linux/errno.h was presumably being included here for some of
the MSR function implementations inside the #fidef. But, even
before those were moved out of the #ifdef, they were not using
anything from errno.h. There does not appear to be any reason to
include it here. Especially inside the (quite small now) #ifdef.
Remove the #include.
?
