On 26/05/16 11:40AM, Jonathan Cameron wrote:
> On Wed, 13 May 2026 16:09:24 +0100
> Rodrigo Alencar <[email protected]> wrote:
>
> > On 26/05/12 07:31PM, Jonathan Cameron wrote:
> > > On Fri, 08 May 2026 18:00:17 +0100
> > > Rodrigo Alencar via B4 Relay
> > > <[email protected]> wrote:
> > >
> > > > From: Rodrigo Alencar <[email protected]>
> > > >
> > > > DT-bindings for AD9910, a 1 GSPS DDS with 14-bit DAC. It includes
> > > > configurations for clocks, DAC current, reset and basic GPIO control.
> > >
> > > I think this is getting close enough now that for next version you should
> > > drop the RFC (which is probably gating DT binding folk giving it
> > > a detailed review!)
> > >
> > > >
> > > > Signed-off-by: Rodrigo Alencar <[email protected]>
> > >
> > > > +
> > > > + adi,dac-output-current-microamp:
> > > > + minimum: 8640
> > > > + maximum: 31590
> > > > + default: 20070
> > > > + description:
> > > > + DAC full-scale output current in microamps.
> > > > +
> > > Can we use generic dac.yaml defined output-range-microamp? The base will
> > > be 0 always but
> > > that shouldn't matter.
> > >
> >
> > would that be fine even if we do not have those child channel nodes in the
> > device-tree node?
> >
> I think I'd rather we generalized to cover the 'one shared value' case rather
> then went with a vendor specific binding.
I can't reference dac.yaml in node level as it forces the nodename to match a
pattern:
dds@0 (adi,ad9910): $nodename:0: 'dds@0' does not match
'^channel(@[0-9a-f]+)?$'
Also, I can't reference the property only, because it ends with *-microamp:
output-range-microamp:
$ref: /schemas/iio/dac/dac.yaml#/properties/output-range-microamp
items:
- const: 0
- minimum: 8640
maximum: 31590
default: 20070
which gets me:
properties:output-range-microamp: '$ref' should not be valid under
{'const': '$ref'}
so I will adjust it to:
output-range-microamp:
description: DAC full-scale output current in microamps.
items:
- const: 0
- minimum: 8640
maximum: 31590
default: 20070
and not reference dac.yaml at all.
--
Kind regards,
Rodrigo Alencar
