On Mon, Jun 01, 2026 at 08:57:30PM +0200, David Sterba wrote: > On Sat, May 30, 2026 at 05:28:12PM -0700, Eric Biggers wrote: > > On Fri, May 22, 2026 at 09:00:46AM +0200, Daniel Vacek wrote: > > > It's been really hard to find time to review this huge patchset. I've > > started going through it and will try to leave comments next week. > > Thank you. The patchset is huge but we'd like your feedback namely on > the crypto layer changes, i.e. the first 8 patches.
I know, but properly reviewing those patches requires reviewing their usage in btrfs too. Plus the whole feature needs to be solid: if there's a problem with it that's my problem too. And some problems, e.g. any in the on-disk format, would be unfixable later, so we have to get them right from the beginning. > It's too late for 7.2 also because you've asked for some changes. I think the Sashiko reviews alone make it very clear that this needs some more work. So if you're considering this to be ready and just waiting for me, I don't think that's the best way to move this forwards. > I'm not sure if it was mentioned before wrt how to get this merged. My > preferred way is to get your Ack for the crypto changes and then we can > add it to linux-next via our btrfs git. That will be fine once it's ready. - Eric
