On 02/10/2008 04:37 AM, S.Çağlar Onur wrote:
Hi;
Following patch silents
drivers/mtd/ubi/vmt.c: In function `ubi_create_volume':
drivers/mtd/ubi/vmt.c:379: warning: statement with no effect
compiler warning introduced by commit 801c135ce73d5df1caf3eca35b66a10824ae0707
(UBI: Unsorted Block Images)
Signed-off-by: S.Çağlar Onur <[EMAIL PROTECTED]>
drivers/mtd/ubi/vmt.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/ubi/vmt.c b/drivers/mtd/ubi/vmt.c
index a3ca225..eafeaf0 100644
--- a/drivers/mtd/ubi/vmt.c
+++ b/drivers/mtd/ubi/vmt.c
@@ -376,7 +376,7 @@ out_sysfs:
get_device(&vol->dev);
volume_sysfs_close(vol);
out_gluebi:
- ubi_destroy_gluebi(vol);
+ err = ubi_destroy_gluebi(vol);
out_cdev:
cdev_del(&vol->cdev);
out_mapping:
I think this is not correct. You change the err which caused the failure. You
change it even to 0 if it doesn't fail and the whole function will seem like
non-failing.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/