Hi;
10 Şub 2008 Paz tarihinde, Jiri Slaby şunları yazmıştı:
> I think this is not correct. You change the err which caused the failure. You
> change it even to 0 if it doesn't fail and the whole function will seem like
> non-failing.
My bad, sorry for not looking carefully. Assuming a refactoring is not desired
for just a compiler warning, is following acceptable (this kind of plain
messages seems heavily used in vmt.c, so i'm again assuming its OK to use such
style)?
commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Images)
introduced the warning
drivers/mtd/ubi/vmt.c: In function `ubi_create_volume':
drivers/mtd/ubi/vmt.c:379: warning: statement with no effect
drivers/mtd/ubi/vmt.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/ubi/vmt.c b/drivers/mtd/ubi/vmt.c
index a3ca225..46410f6 100644
--- a/drivers/mtd/ubi/vmt.c
+++ b/drivers/mtd/ubi/vmt.c
@@ -376,7 +376,8 @@ out_sysfs:
get_device(&vol->dev);
volume_sysfs_close(vol);
out_gluebi:
- ubi_destroy_gluebi(vol);
+ if(ubi_destroy_gluebi(vol))
+ ubi_err("cannot destroy device");
out_cdev:
cdev_del(&vol->cdev);
out_mapping:
Cheers
--
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/
Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
