On Sun, 2026-08-02 at 20:40 +0200, Stefan Hansson wrote: > Hello Johannes, > > On 02/08/2026 18:24, Johannes Berg wrote: > > On Sun, 2026-08-02 at 14:22 +0200, Stefan Hansson wrote: > > > Avoids errors like: > > > > > > CFI failure at kthread+0x124/0x1cc (target: > > > rsi_coex_scheduler_thread+0x0/0x1b4 [redpine_91x]; expected type: > > > 0x89fb613d) > > > > Yeah, well. Everyone gets _one_ warning to send patches that actually > > build warning-free, after that I just drop them without notice... > > Could you clarify what you are referring to here? I don't get any errors > when building after applying this patch on top of next-20260730:
Alright, so it does build, sorry. I was just looking at nipa: https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/ But I see now it's just duplicating the kernel-doc issues across all the builds ... I wasn't paying attention to _what_ it was reporting and the kthread_complete_and_exit() use in the functions and thought it was likely getting "control reaches end of non-void function" warnings since you change functions to int without ever returning anything. > If you are referring to checkpatch.pl complaining about the > aforementioned error line being too long, I can wrap it if you prefer that. Nah, that's fine, no worries. johannes
