On 04/08/2026 09:39, Ondřej Jirman wrote:
Hi,
On Sat, Aug 01, 2026 at 02:35:21AM +0200, David Heidelberg via B4 Relay wrote:
From: David Heidelberg <[email protected]>
By datasheet the VDD (in-kernel named vcc) range is between 2.3 to 4.3 V.
Usually it's around 2.8 V. Here it matches the avdd2v8_dvp.
Fixes: 9336eb829a18 ("arm64: dts: rockchip: describe I2c Bus 1 and IMX258 world
camera on PinePhone Pro")
Cc: [email protected]
Signed-off-by: David Heidelberg <[email protected]>
---
arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
index d46cdfe3f7849..bde35d9b2263e 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
@@ -473,17 +473,17 @@ wcam_out: endpoint {
};
};
};
wcam_lens: camera-lens@c {
compatible = "dongwoon,dw9714";
reg = <0x0c>;
/* Same I2c bus as both cameras, depends on vcca1v8_codec for
power. */
- vcc-supply = <&vcc1v8_dvp>;
+ vcc-supply = <&avdd2v8_dvp>;
This does not match reality, schematic says it's VCC2V8_DVP:
https://xff.cz/dl/tmp/6253a0465329df41.png
Ahoj,
thanks for spotting this, since I know you have the device, would be too much to
ask you to send standalone fix for PP Pro?
I would drop the change from the series.
David
P.S. I noticed I didn't mark this series RFC. Too late.
regards,
o.
};
ucam: camera@36 {
compatible = "ovti,ov8858";
reg = <0x36>;
clocks = <&cru SCLK_CIF_OUT>; /* MIPI_MCLK1, derived from
CIF_CLK0 */
clock-names = "xvclk";
dovdd-supply = <&vcc1v8_dvp>;
--
2.53.0
--
David Heidelberg
