> Unwind IRQs already requested by snet_request_irqs() before returning a > VQ IRQ request error so a later DRIVER_OK retry starts from a clean > state. The IRQs are requested and freed while the PCI device remains > bound, so the driver cannot wait for devres cleanup at detach time.
I suggest to avoid duplicate SNET_ERR() calls for the implementation of the function “snet_request_irqs”. https://elixir.bootlin.com/linux/v7.2-rc5/source/drivers/vdpa/solidrun/snet_main.c#L400-L426 Regards, Markus
