> > + - IFA_F_PERMANENT marks entries added with SIOCADDMULTI > > + (netdev_hw_addr::global_use, "static" in "ip maddr") > The global flag is also set for addresses added via dev_mc_add_excl(), ie by > some drivers.
Thanks for the reminder, will fix the comment in patchset v3 > > + ifm->ifa_flags = ha->global_use ? IFA_F_PERMANENT : 0; > I wonder if adding a new attribute IFA_F_GLOBAL would not make the API more > understandable. Good point, IFA_F_GLOBAL is indeed a better API that will fixed in patchset v3. > > + struct net *net = sock_net(skb->sk); > For consistency with ipv4/ipv6, it would be nice to handle IFA_TARGET_NETNSID. Will do in v3. Thanks, Yuyang
