> On 09/14/2026 4:31 AM PDT Naman Jain <[email protected]> wrote:
>
>
> On 9/12/2026 9:05 AM, Roman Kisel wrote:
> > On Mon, Aug 31, 2026 at 08:25:28AM +0000, Naman Jain wrote:
[...]
> >> +void get_rtc_noop(struct timespec64 *now) { *now = (struct
> >> timespec64){0}; }
> >
> > Hi Naman,
> >
> > Could be
> >
> > *now = (struct timespec64){};
> >
> > to save a byte :)
>
> hi Roman,
> Thanks for reviewing.
>
> Tianyu pointed out offline that this is handled in yet another way in
> jailhouse code:
>
> arch/x86/kernel/jailhouse.c
> static void jailhouse_get_wallclock(struct timespec64 *now)
> {
> memset(now, 0, sizeof(now));
> }
Appreciate sharing! Makes sense to me, looks way more explicit. Most
importantly imo, the memset isn't actually producing a call here so
the clock no-op stays cheap when choosing `memset` over ` = {}`.
One can see that the kernel build compiles ` = {0}`, ` = {}` into
pxor ...
movups ...
on x64 in the above. I made sure the memset "call" is relaxed/optimized
away into the same sequence `pxor ...; movups ...`.
>
> Regards,
> Naman
>
> >
> > LGTM.
> > Reviewed-by: Roman Kisel <[email protected]>
> >
> >>
> >> static __initconst const struct of_device_id of_cmos_match[] = {
> >> { .compatible = "motorola,mc146818" },
> >> --
> >> 2.43.0
> >>
