> - [Medium] Concurrent device removal can end an unfiltered AF_PACKET
>   RTM_GETMULTICAST dump early without setting NLM_F_DUMP_INTR.

This window is in unlist_netdevice(), the device leaves the index
before dev_base_seq is bumped. Moreover, it seems it affects the IPv4
and IPv6 address
dumps the same way. If it should be fixed, it seems it needs to be
fixed seapartely, not a new issue introduced in this patchset.

> - [Low] The commit message gives a false reason for not extending the FDB
>   dump.
> - [Low] dev_mc_genid is only bumped through the __hw_addr_count_*
>   helpers, i.e. when a dev->mc entry is added or removed.

Agreed on both, but they are nits, will adjust if there is a v10.

> - [Low] At this commit, Documentation/netlink/specs/rt-addr.yaml does not
>   describe the new AF_PACKET multicast dump: - The ifa-flags enum stops…

The spec update is the next patch.

Reply via email to