On Wed, 30 Sep 2026 20:28:40 +0900 Yuyang Huang wrote:
> +     netdev_for_each_mc_addr(ha, dev) {
> +             if (addr_idx < *s_addr_idx) {
> +                     addr_idx++;
> +                     continue;
> +             }
> +             err = dev_mc_fill_addr(skb, dev, ha, NETLINK_CB(cb->skb).portid,
> +                                    cb->nlh->nlmsg_seq, flags, netnsid);
> +             if (err < 0)
> +                     break;
> +             nl_dump_check_consistent(cb, nlmsg_hdr(skb));

Why are you checking this on every iteration?

> +             addr_idx++;
> +     }

The changes still lack polish IMO.

Reply via email to