On Tue, Oct 06, 2026 at 04:49:12PM +0300, Muzaffer Kadir wrote: > On Tue, 6 Oct 2026 16:19:04 +0300, Dmitry Baryshkov wrote: > > On Tue, Oct 06, 2026 at 03:15:11PM +0300, Muzaffer Kadir via B4 Relay wrote: > >> From: Muzaffer Kadir <[email protected]> > >> > >> Add support for tsens v1 block that exists on MSM8952 > >> with 11 tsens sensors. Sensor Offsets and slope values > >> are taken from downstream. > >> > >> Link: > >> https://android.googlesource.com/kernel/msm.git/+/refs/tags/android-wear-7.0.0_r0.3/drivers/thermal/msm-tsens.c#1621 > >> Signed-off-by: Muzaffer Kadir <[email protected]> > >> --- > >> drivers/thermal/qcom/tsens-v1.c | 44 > >> +++++++++++++++++++++++++++++++++++++++++ > >> drivers/thermal/qcom/tsens.c | 3 +++ > >> drivers/thermal/qcom/tsens.h | 2 +- > >> 3 files changed, 48 insertions(+), 1 deletion(-) > >> > >> diff --git a/drivers/thermal/qcom/tsens-v1.c > >> b/drivers/thermal/qcom/tsens-v1.c > >> index faa5d00788ca..f4201748ea29 100644 > >> --- a/drivers/thermal/qcom/tsens-v1.c > >> +++ b/drivers/thermal/qcom/tsens-v1.c > >> @@ -145,6 +145,37 @@ static const struct reg_field > >> tsens_v1_regfields[MAX_REGFIELDS] = { > >> [TRDY] = REG_FIELD(TM_TRDY_OFF, 0, 0), > >> }; > >> > >> +static int __init init_8952(struct tsens_priv *priv) > >> +{ > >> + for (int i = 0; i < priv->num_sensors; ++i) > >> + priv->sensor[i].slope = 3200; > > > > Where are these values coming from? The driver that you pointed out > > reads them from the QFPROM (like other tsens platforms do). > > Hi Dmitry, > > Slope is coming from this: > https://android.googlesource.com/kernel/msm.git/+/refs/tags/android-wear-7.0.0_r0.3/arch/arm/boot/dts/qcom/msm8952.dtsi#550 > > calib_offset values are coming from these: > https://android.googlesource.com/kernel/msm.git/+/refs/tags/android-wear-7.0.0_r0.3/drivers/thermal/msm-tsens.c#1756 > https://android.googlesource.com/kernel/msm.git/+/refs/tags/android-wear-7.0.0_r0.3/drivers/thermal/msm-tsens.c#1800 > > Should I drop them?
The slope you are setting matches the SLOPE_DEFAULT, so I guess it can be removed. With that in place: Reviewed-by: Dmitry Baryshkov <[email protected]> -- With best wishes Dmitry
