On Thu, 21 Feb 2008 22:50:54 +0900 (JST) Atsushi Nemoto <[EMAIL PROTECTED]> wrote:
> Fix NCFGR.SPD setting on 10Mbps. This bug was introduced by > conversion to generic PHY layer in kernel 2.6.23. > > Signed-off-by: Atsushi Nemoto <[EMAIL PROTECTED]> > --- > diff --git a/drivers/net/macb.c b/drivers/net/macb.c > index 81bf005..1d210ed 100644 > --- a/drivers/net/macb.c > +++ b/drivers/net/macb.c > @@ -148,7 +148,7 @@ static void macb_handle_link_change(struct net_device > *dev) > > if (phydev->duplex) > reg |= MACB_BIT(FD); > - if (phydev->speed) > + if (phydev->speed == SPEED_100) I have to admit that even after looking through include/linux/phy.h and include/linux/mii.h, I don't have the faintest idea what values we can expect to find in the "speed" field of phydev. The comment above struct phy_device says that it is used "like in mii_if_info", but struct mii_if_info doesn't have a "speed" field... I'm willing to take your word for it, but some documentation would be really nice... Haavard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
