Linus Torvalds wrote:
On Thu, 21 Feb 2008, Jeremy Fitzhardinge wrote:
OK. Have you fixed it, or shall I resend?
I'll fix it, but I want people to know so that I don't have to fix things
like this in the future (*).
Linus
(*) I keed, I keed. Of *course* I'll have to fix things like this in the
future too. But hopefully not quite as often.
Putting the From: in the Signed-off-by block is a result of two thoughts:
1. putting it at the top makes the most sense from an email
perspective, but it often seem to get lost by various
patch-posting programs if it gets tangled in the Subject/summary
part of the patch. The result is that it needs to float in an odd
way:
Subject: wooble the foo
From: Foo Woobler <[EMAIL PROTECTED]>
Wooble foos in the appropriate manner.
Signed-off-by: Foo Woobler <[EMAIL PROTECTED]>
Cc: Bar Mangler <[EMAIL PROTECTED]>
2. There's already a block of email addresses which describe how
people relate to this patch, so why not put From: there (since it
isn't really an email From header, but a patch metadata header).
I'd assumed that tools which pick "Thing: Email" pairs out of a
patch would deal with From in the same place as a Signed-off-by.
After all, tools deal with Cc:s there.
I'll make sure From: is in the right place in future, but I just wanted
to point out it wasn't complete randomness.
J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
