I agree.

On Sun, Jul 8, 2012 at 5:36 PM, Jan Ceuleers <[email protected]> wrote:
> On 07/08/2012 10:16 AM, Toshiaki Yamane wrote:
>> -printk(KERN_ERR, to pr_err(...
>>
>> Signed-off-by: Toshiaki Yamane <[email protected]>
>
> Hi
>
> I submit that your subject line should be more descriptive. Perhaps
> something like the following:
>
> [PATCH] asus_oled: Use pr_err(...) rather than printk(KERN_ERR ...)
>
> The rest of your commit message could then clarify that this change was
> inspired by checkpatch.
>
> HTH, Jan



-- 

Regards,


 .
  .
...

Yamane Toshiaki

[email protected]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to