On Thu, Jul 12, 2012 at 2:34 PM, Alan Cox <[email protected]> wrote: > On Thu, 12 Jul 2012 11:54:28 +0545 > Devendra Naga <[email protected]> wrote: > >> TCB has kcalloc' ed so no need to call memset again on it. >> >> Signed-off-by: Devendra Naga <[email protected]> >> --- >> drivers/staging/et131x/et131x.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/staging/et131x/et131x.c >> b/drivers/staging/et131x/et131x.c >> index 227fca9..5010894 100644 >> --- a/drivers/staging/et131x/et131x.c >> +++ b/drivers/staging/et131x/et131x.c >> @@ -2131,8 +2131,6 @@ static void et131x_init_send(struct et131x_adapter >> *adapter) >> >> tx_ring->tcb_qhead = tcb; >> >> - memset(tcb, 0, sizeof(struct tcb) * NUM_TCB); > > Its such a rarely used path with several entry points that it's probably > safer kept as is. > Hi Alan Sir,
Glad to see your reply, I really didn't saw the whole code paths, was seeing the ring allocations, sorry for the noise. > Alan Thanks, Devendra. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
