Hello, On Tue, Jul 17, 2012 at 05:29:27PM -0400, Aristeu Rozanski wrote: > what about this version:
Yeah, generally looks good to me although @added/removed_bits argument names irk me a bit. The name may be okay for local variables but I keep thinking "what bits?". @subsys_mask or something indicating that it's mask of subsystems would better. Also, can you please add /** function comment explaining the clear/populate functions and their arguments? Thanks! -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/