Hello, On Wed, Jul 18, 2012 at 10:16:05AM -0400, Aristeu Rozanski wrote: > > Yeah, generally looks good to me although @added/removed_bits argument > > names irk me a bit. The name may be okay for local variables but I > > keep thinking "what bits?". @subsys_mask or something indicating that > > it's mask of subsystems would better. Also, can you please add /** > > function comment explaining the clear/populate functions and their > > arguments? > > agreed. although the "_bits" thing is spread all around the code. you > want that cleaned up too? (I can post a followup patch after this > patchset is done)
Yeah, that would be great. Thanks a lot! -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
