On Fri, Jul 27, 2012 at 04:55:07PM -0700, Tejun Heo wrote: > Convert delayed_work users doing [__]cancel_delayed_work() + > queue_delayed_work() to mod_delayed_work(). > > Most conversions are straight-forward. Ones worth mentioning are, > > * drivers/edac/edac_mc.c: edac_mc_workq_setup() converted to always > use mod_delayed_work() and cancel loop in > edac_mc_reset_delay_period() is dropped. > > * drivers/platform/x86/thinkpad_acpi.c: No need to remember whether > watchdog is active or not. @fan_watchdog_active and related code > dropped. > > * drivers/power/charger-manager.c: Seemingly a lot of > delayed_work_pending() abuse going on here. > [delayed_]work_pending() are unsynchronized and racy when used like > this. I converted one instance in fullbatt_handler(). Please > conver the rest so that it invokes workqueue APIs for the intended > target state rather than trying to game work item pending state > transitions. e.g. if timer should be modified - call > mod_delayed_work(), canceled - call cancel_delayed_work[_sync](). > > * drivers/thermal/thermal_sys.c: thermal_zone_device_set_polling() > simplified. Note that round_jiffies() calls in this function are > meaningless. round_jiffies() work on absolute jiffies not delta > delay used by delayed_work. > > * net/core/link_watch.c: linkwatch_schedule_work() was doing a quite > elaborate dancing around its delayed_work. Collapse it such that > linkwatch_work is queued for immediate execution if LW_URGENT and > existing timer is kept otherwise. > > Signed-off-by: Tejun Heo <t...@kernel.org> > Cc: Jens Axboe <ax...@kernel.dk> > Cc: Jiri Kosina <jkos...@suse.cz> > Cc: Doug Thompson <dougthomp...@xmission.com> > Cc: David Airlie <airl...@linux.ie> > Cc: Roland Dreier <rol...@kernel.org> > Cc: Dmitry Torokhov <dmitry.torok...@gmail.com>
For the input parts: Acked-by: Dmitry Torokhov <dmitry.torok...@gmail.com> Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
