On 08/08/2012 05:37 PM, Alan Cox wrote: > On Tue, 7 Aug 2012 21:47:43 +0200 > Jiri Slaby <[email protected]> wrote: > >> Switch to the new driver allocation interface, as this is one of the >> special call-sites. Here, we need TTY_DRIVER_EXCESSIVE_LINES to not >> allocate tty_driver->ports, cdevs and potentially other structures >> because we reserve too many lines in pty. Instead, it provides the >> tty_port<->tty_struct link in tty->ops->install already. > > This is the only thing I would quibble about in the entire patch set. > > We've got a pile of things that the pty does and one or two other > drivers might want to do about dynamic allocation (termios objects is > the same problem). > > I think it's a mistake to call it EXCESSIVE_LINES, better a name which > indicates what it implies - say TTY_DRIVER_DYNAMIC_ALLOC. Then it means > other drivers can move that way if they wish.
I would stick only to the rename at this moment -- I will send a v2 for this and 19/41. The merge with DEVPTS_MEM (the termios case) needs devpts_kill_index to be moved from tty_release to pty_driver->ops->cleanup/shutdown, but I don't feel comfortable to do it now since it needs some testing. So I would add this to TODO and will send it after the next merge window. If I understood your point correctly? > for the entire series, and next time we are both at the same conference > I owe you a a couple of beers at least ! Heh, OK, it would be honor for me ;). thanks, -- js suse labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
