* Arnaldo Carvalho de Melo <[email protected]> wrote:

> static int process_sample_event(struct perf_tool *tool __used,
>                               union perf_event *event,
>                               struct perf_sample *sample,
>                               struct perf_evsel *evsel,
>                               struct machine *machine)

Just saw this 5-parameter function signature fly by: as a 
separate clean-up it would be really neat to stick most of these 
into an intuitively named helper structure or so. 

struct event_context ectx?

That would make extension of the context easier as well in the 
future. Or so.

Thanks,

        Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to