On Mon, 2012-08-13 at 15:52 +0200, Peter Zijlstra wrote: > > Looking at the history of perf_trace_buf_submit(), it use to be more > > than one function call. But when you inlined > > perf_swevent_put_recursion_context(), it became just a one2one mapping. > > Right.
OK, this should go as a separate change. > > > I'm assuming that we want to convert all calls to > > perf_trace_buf_submit()s into perf_tp_event()? > > Yeah.. I think you're referring to the {u,k}probes open-coded nonsense? > Should we make those use these new helpers you created as well? They may not need it. The helpers I created were for the macros that are created by all TRACE_EVENT() instances. If the uprobes and kprobes only have a single instance, then they probably don't need the helpers. But they still call the perf_trace_buf_submit(), which can can probably be cleaned up. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/