On Wed, Aug 22, 2012 at 05:13:10PM +0200, Arnd Bergmann wrote: > On i.MX6, we select ARM_CPU_SUSPEND when building with power management > support, but for some reason this was omitted on i.MX5. Normally we > build kernels for both together so the error only showed up in > randconfig tests. > > Without this patch, building imx5 standalone results in: > > arch/arm/mach-imx/built-in.o: In function `v7_cpu_resume': > arch/arm/mach-imx/head-v7.S:104: undefined reference to `cpu_resume' > So far, none of the functions in head-v7.S is used on imx5. Also since imx5 SoCs implement State Retention Power Gating in hardware, ARM_CPU_SUSPEND support will never be used on imx5.
Maybe we should make head-v7.S only compile for imx6? Regards, Shawn > Signed-off-by: Arnd Bergmann <a...@arndb.de> > Cc: Eric Miao <eric.m...@linaro.org> > Cc: Shawn Guo <shawn....@linaro.org> > Cc: sta...@vger.kernel.org > --- > arch/arm/mach-imx/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig > index afd542a..8e96573 100644 > --- a/arch/arm/mach-imx/Kconfig > +++ b/arch/arm/mach-imx/Kconfig > @@ -89,6 +89,7 @@ config SOC_IMX5 > select ARCH_MXC_IOMUX_V3 > select ARCH_HAS_CPUFREQ > select ARCH_MX5 > + select ARM_CPU_SUSPEND if PM > bool > > config SOC_IMX50 > -- > 1.7.10 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
