On 8/23/2012 5:48 AM, David Howells wrote: > Casey Schaufler <ca...@schaufler-ca.com> wrote: > >> From: Casey Schaufler <ca...@schaufler-ca.com> >> Subject: [PATCH] Smack: setprocattr memory leak fix >> >> The data structure allocations being done in prepare_creds >> are duplicated in smack_setprocattr. This results in the >> structure allocated in prepare_creds being orphaned and >> never freed. The duplicate code is removed from >> smack_setprocattr. >> >> Targeted for git://git.gitorious.org/smack-next/kernel.git >> >> Signed-off-by: Casey Schaufler <ca...@schaufler-ca.com> > Acked-by: David Howells <dhowe...@redhat.com>
Thanks for the review. > Note that I do have a patch to make Smack share rule lists - I've posted it a > number of times, but I take it you're not interested. The patch is a big chunk of code and the feature isn't getting used to the extent that the people who requested it seemed certain it would be. I don't see there being value in optimizing the per-task rule lists given the amount of use they get. > > 5707 06/13 [To:casey@schauf] [PATCH 1/3] Smack: Constify some > pointers<<Mak > 5708 06/13 [To:casey@schauf] [PATCH 2/3] Smack: Further > constification<<M > 5709 06/13 [To:casey@schauf] [PATCH 3/3] Smack: Use rule list tail > sharin > > David > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
