On Thu, Aug 23, 2012 at 07:17:41PM +0800, Mark Brown wrote: > On Thu, Aug 23, 2012 at 03:15:04PM +0800, Dong Aisheng wrote: > > On Wed, Aug 22, 2012 at 11:59:53PM +0800, Mark Brown wrote: > > > > With the conversion to regmap it'd also be good to convert the driver to > > > use the regmap helper functions for enable and voltage operations if > > > possible. > > > The anatop-regulator driver only implements set_voltage_sel/get_voltage_sel > > which i have already converted, what do you mean others like > > 'for enable and voltage operations' i should also convert? > > Those operations should ideally be converted to use the generic regmap > implementation now the device uses regmap - regmap_get_voltage_sel_regmap > and so on.
Okay, got it. Regards Dong Aisheng -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
