On Wed, Aug 29, 2012 at 06:56:53PM +0800, Dong Aisheng wrote: > From: Dong Aisheng <dong.aish...@linaro.org> > > Include headfile for easy using. > > Acked-by: Stephen Warren <swar...@wwwdotorg.org> > Signed-off-by: Dong Aisheng <dong.aish...@linaro.org> > --- > arch/arm/boot/dts/imx6q.dtsi | 5 + > include/linux/fsl/imx6q-iomuxc-gpr.h | 319 > ++++++++++++++++++++++++++++++++++
I assume that all the users of this header file are imx6q syscon clients. In that case, this header belongs to mfd/syscon subsystem. I have been told by people that it was a mistake to create include/linux/fsl. Each header in include/linux should go to respective subsystem sub-directory. For this particular case, it should be include/linux/mfd or include/linux/mfd/syscon even better, IMO. <snip> > +#define IMX6Q_GPR13_SATA_PHY_1_MED (0x1 << 0) > +#define IMX6Q_GPR13_SATA_PHY_1_SLOW (0x2 << 0) > + > +#endif /* !__LINUX_IMX6Q_IOMUXC_GPR_H */ Nit: why do we have a "!" there? -- Regards, Shawn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
