Doug Anderson wrote: > > On Thu, Sep 6, 2012 at 8:21 AM, Daniel Kurtz <[email protected]> wrote: > > chained_irq_enter/exit() already mask&ack/unmask the chained interrupt. > > There is no need to also explicitly do it in the handler. > > > > Signed-off-by: Daniel Kurtz <[email protected]> > > --- > > arch/arm/mach-exynos/common.c | 7 ------- > > 1 files changed, 0 insertions(+), 7 deletions(-) > > > > diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach- > exynos/common.c > > index 4eb39cd..0a85aec 100644 > > --- a/arch/arm/mach-exynos/common.c > > +++ b/arch/arm/mach-exynos/common.c > > @@ -965,14 +965,7 @@ static void exynos_irq_eint0_15(unsigned int irq, > struct irq_desc *desc) > > struct irq_chip *chip = irq_get_chip(irq); > > > > chained_irq_enter(chip, desc); > > - chip->irq_mask(&desc->irq_data); > > - > > - if (chip->irq_ack) > > - chip->irq_ack(&desc->irq_data); > > - > > generic_handle_irq(*irq_data); > > - > > - chip->irq_unmask(&desc->irq_data); > > chained_irq_exit(chip, desc); > > } > > > > -- > > 1.7.7.3 > > > > Acked-by: Doug Anderson <[email protected]>
Yes, will apply. Thanks. Best regards, Kgene. -- Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
