On Tue, Sep 18, 2012 at 05:36:44PM -0600, Jim Cromie wrote:
> Tell user how big the attempted write was, in case its not obvious.
> This helped identify a missing flush in my stress-test script.
>
> Signed-off-by: Jim Cromie <jim.cro...@gmail.com>
> ---
> lib/dynamic_debug.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
> index 43ae319..85258a8 100644
> --- a/lib/dynamic_debug.c
> +++ b/lib/dynamic_debug.c
> @@ -693,7 +693,8 @@ static ssize_t ddebug_proc_write(struct file *file, const
> char __user *ubuf,
> if (len == 0)
> return 0;
> if (len > USER_BUF_PAGE - 1) {
> - pr_warn("expected <%d bytes into control\n", USER_BUF_PAGE);
> + pr_warn("expected <%d bytes into control, you wrote %d\n",
> + USER_BUF_PAGE, (int) len);
The style here, I think, is generally to leave out the space, ie: (int)len.
Thanks,
-Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
