On Thu, Sep 27, 2012 at 01:46:17PM +0530, viresh kumar wrote:
> On Thu, Sep 27, 2012 at 1:10 PM, Felipe Balbi <ba...@ti.com> wrote:
> >> diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
> 
> >> @@ -1700,6 +1700,7 @@ MODULE_DEVICE_TABLE(of, dw_dma_id_table);
> >>  #endif
> >>
> >>  static struct platform_driver dw_driver = {
> >> +     .probe          = dw_probe,
> >
> > probe's in __init section. This is wrong. You need to change probe
> > __devinit.
> 
> Good one. How can i miss it. :(
> 
> @Andy: Please add my Acked-by: after this change.

after this change you can also add:

Reviewed-by: Felipe Balbi <ba...@ti.com>

-- 
balbi

Attachment: signature.asc
Description: Digital signature

Reply via email to