On Thu, Sep 27, 2012 at 1:45 AM, <[email protected]> wrote: > From: Yasuaki Ishimatsu <[email protected]> > > When calling remove_memory_block(), the function shows following message at > device_release(). > > Device 'memory528' does not have a release() function, it is broken and must > be fixed. > > remove_memory_block() calls kfree(mem). I think it shouled be called from > device_release(). So the patch implements memory_block_release()
Why do you think so? This is terribly bad change log. it has almost zero information. We can't review it. > > CC: David Rientjes <[email protected]> > CC: Jiang Liu <[email protected]> > CC: Len Brown <[email protected]> > CC: Benjamin Herrenschmidt <[email protected]> > CC: Paul Mackerras <[email protected]> > Cc: Minchan Kim <[email protected]> > CC: Andrew Morton <[email protected]> > CC: KOSAKI Motohiro <[email protected]> > CC: Wen Congyang <[email protected]> > Signed-off-by: Yasuaki Ishimatsu <[email protected]> > --- > drivers/base/memory.c | 9 ++++++++- > 1 files changed, 8 insertions(+), 1 deletions(-) > > diff --git a/drivers/base/memory.c b/drivers/base/memory.c > index 7dda4f7..da457e5 100644 > --- a/drivers/base/memory.c > +++ b/drivers/base/memory.c > @@ -70,6 +70,13 @@ void unregister_memory_isolate_notifier(struct > notifier_block *nb) > } > EXPORT_SYMBOL(unregister_memory_isolate_notifier); > > +static void release_memory_block(struct device *dev) > +{ > + struct memory_block *mem = container_of(dev, struct memory_block, > dev); > + > + kfree(mem); > +} > + > /* > * register_memory - Setup a sysfs device for a memory block > */ > @@ -80,6 +87,7 @@ int register_memory(struct memory_block *memory) > > memory->dev.bus = &memory_subsys; > memory->dev.id = memory->start_section_nr / sections_per_block; > + memory->dev.release = release_memory_block; > > error = device_register(&memory->dev); > return error; > @@ -630,7 +638,6 @@ int remove_memory_block(unsigned long node_id, struct > mem_section *section, > mem_remove_simple_file(mem, phys_device); > mem_remove_simple_file(mem, removable); > unregister_memory(mem); > - kfree(mem); > } else > kobject_put(&mem->dev.kobj); > > -- > 1.7.1 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to [email protected]. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"[email protected]";> [email protected] </a> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
