Hello, On Fri, Sep 28, 2012 at 06:04:01PM +0800, Lai Jiangshan wrote: > On 09/27/2012 02:24 AM, Tejun Heo wrote: > > On Thu, Sep 27, 2012 at 01:20:34AM +0800, Lai Jiangshan wrote: > >> There is no reason to use WORKER_PREP, remove it from rescuer. > >> > >> And there is no reason to set it so early in alloc_worker(), > >> move "worker->flags = WORKER_PREP" to start_worker(). > > > > Merge this with the patch to add RESCUER to NOT_RUNNING? > > Don't merge. the change log is not good. > I should list all the purposes of WORKER_PREP(I did it in my note), > and then we can claim that we don't need to add WORKER_PREP show early. > > These two patches do different things.
Hmmm? You're replacing WORKER_PREP with RESCUER for NOT_RUNNING marking. I don't see why they need to be separate patches. Just explain what's going on in the commit message. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
