> -----Original Message----- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of David Miller > Sent: Tuesday, October 16, 2012 1:17 PM > To: bhutchi...@solarflare.com > Cc: richardcoch...@gmail.com; haicheng...@linux.intel.com; > net...@vger.kernel.org; tshimizu...@gmail.com; linux- > ker...@vger.kernel.org; haicheng....@gmail.com > Subject: Re: [PATCH 1/2] Fix build error caused by broken PCH_PTP module > dependency. > > From: Ben Hutchings <bhutchi...@solarflare.com> > Date: Tue, 16 Oct 2012 21:09:27 +0100 > > > I think the various kconfig options should be changed as follows: > > > > 1. Only PTP_1588_CLOCK selects PPS. > > 2. Nothing depends on EXPERIMENTAL. (This stuff has been in for 18 > > months and it's even being backported to RHEL 6 now.) > > 3. Either: > > (a) The per-driver PHC options select nothing, and the driver options > > do e.g.: > > select PTP_1588_CLOCK if IGB_PTP > > (b) The per-driver PHC options are removed and the driver options do: > > select PTP_1588_CLOCK > > (i.e. PHC support is unconditional) > > > > Any objections to this, or preference for (a) vs (b)? > > No objections, prefer (b).
No objections here, I also prefer (b). The feature shouldn't have much impact unless enabled via hwtstamp_ioctl, and it drastically reduces requirement on end-user needing to enable PHC support. - Jake > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
