On 10/18/2012 04:01 AM, Linus Walleij wrote: > This switches the way that pins are reserved for multiplexing:
The conceptual change makes perfect sense to me. > diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c > void pinmux_free_setting(struct pinctrl_setting const *setting) ... > + /* > + * If a setting is active, disable it so that all pins are released > + */ > + pinmux_disable_setting(setting); "*If* a setting is active ..." implies there should be a C if statement here to check if the setting is actually active before trying to disable it? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/