Hi Rusty, On Fri, 19 Oct 2012 11:53:15 +1030 Rusty Russell <ru...@rustcorp.com.au> wrote: > > Linus Torvalds <torva...@linux-foundation.org> writes: > > On Wed, Oct 17, 2012 at 10:34 PM, Rusty Russell <ru...@rustcorp.com.au> > > wrote: > >> > >> Hacking the keyid and signer-name to be extracted every time by > >> sign-file takes my modules_install time from 18.6 seconds to 19.1. We'd > >> get that back easily by making sign-file a perl script anyway; it calls > >> out to perl 3 times already. > > > > Ok, that tiny slowdown seems worth the cleanup, especially if we'd get > > it back from somebody re-writing it in perl. > > > > Want to sign off on the two patches, or put them in your git tree? > > Smerged them together: no point moving the x509keyid script now. > I dropped the optional dst arg, since we don't use it.
So, this still generates the keys during the normal build, right? That would be a problem for build servers that have limited randomness available to them, I think. -- Cheers, Stephen Rothwell s...@canb.auug.org.au
pgpYUBB2xnsbq.pgp
Description: PGP signature
