From: Ulf Hansson <ulf.hans...@linaro.org> Likely during merge of the below commits ended up breaking compilation: ASoC: Ux500: Enable ux500 MSP driver for Device Tree ASoC: ux500_msp_i2s: better use devm functions and fix error return code
Signed-off-by: Ulf Hansson <ulf.hans...@linaro.org> --- sound/soc/ux500/ux500_msp_i2s.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/sound/soc/ux500/ux500_msp_i2s.c b/sound/soc/ux500/ux500_msp_i2s.c index b7c996e..e6ff328 100644 --- a/sound/soc/ux500/ux500_msp_i2s.c +++ b/sound/soc/ux500/ux500_msp_i2s.c @@ -692,19 +692,15 @@ int ux500_msp_i2s_init_msp(struct platform_device *pdev, if (!msp) return -ENOMEM; - if (np) { - if (!platform_data) { - platform_data = devm_kzalloc(&pdev->dev, - sizeof(struct msp_i2s_platform_data), GFP_KERNEL); - if (!platform_data) - ret = -ENOMEM; - } - } else + if (np && !platform_data) { + platform_data = devm_kzalloc(&pdev->dev, + sizeof(struct msp_i2s_platform_data), GFP_KERNEL); if (!platform_data) - ret = -EINVAL; + return -ENOMEM; + } - if (ret) - goto err_res; + if (!platform_data) + return -EINVAL; dev_dbg(&pdev->dev, "%s: Enter (name: %s, id: %d).\n", __func__, pdev->name, platform_data->id); -- 1.7.10 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/