On Mon, 22 Oct 2012, Konrad Rzeszutek Wilk wrote:
> > > +
> > > int ret;
> > > ret = HYPERVISOR_update_va_mapping(
> > > (unsigned long)__va(pfn << PAGE_SHIFT),
> > > @@ -418,12 +420,13 @@ static enum bp_state decrease_reservation(unsigned
> > > long nr_pages, gfp_t gfp)
> > > scrub_page(page);
> > >
> > > if (xen_pv_domain() && !PageHighMem(page)) {
> > > - ret = HYPERVISOR_update_va_mapping(
> > > - (unsigned long)__va(pfn << PAGE_SHIFT),
> > > - __pte_ma(0), 0);
> > > - BUG_ON(ret);
> > > + if (!xen_feature(XENFEAT_auto_translated_physmap)) {
> > > + ret = HYPERVISOR_update_va_mapping(
> > > + (unsigned long)__va(pfn << PAGE_SHIFT),
> > > + __pte_ma(0), 0);
> > > + BUG_ON(ret);
> > > + }
> > > }
> >
> > this change, unlike the one before, actually makes things different for
> > traditional pv domains in case PageHighMem(page).
>
> How? He is not altering the !PageHighMem check. Just adding a check
> before the hypercall to render it nop on PVH.
sorry, you are right, I need new glasses
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
