-----Original Message-----
From: xen-devel-boun...@lists.xen.org [mailto:xen-devel-boun...@lists.xen.org]
On Behalf Of Jan Beulich
Sent: Friday, October 26, 2012 8:02 PM
To: Liu, Jinsong
Cc: konrad.w...@oracle.com; linux-kernel@vger.kernel.org;
xen-de...@lists.xen.org
Subject: Re: [Xen-devel] [PATCH 1/2] Xen acpi pad implement
>>> "Liu, Jinsong" <jinsong....@intel.com> 10/26/12 8:18 AM >>>
>> +static struct acpi_driver xen_acpi_pad_driver = {
>> + .name = "processor_aggregator",
>> + .class = ACPI_PROCESSOR_AGGREGATOR_CLASS,
>> + .ids = pad_device_ids,
>> + .ops = {
>> + .add = xen_acpi_pad_add,
>
>.remove?
>
>[Jinsong] .remove method not used by any logic now (any possible point use
>it?), so we remove it from our former patch.
Unless there is technical difficulty implementing it, I wouldn't defer adding
that code until the point where something doesn't work anymore.
[Jinsong] No technical difficulty at all, in fact at last version it has
.remove method. I will re-add it.
>Overall I'd recommend taking a look at the cleaned up driver in
>our kernels.
>
>[Jinsong] What's your point here?
There's quite a bit of cleanup/simplification potential here, and rather than
pointing the pieces out individually I would think comparing with what we have
in production use might be worthwhile. But that's up to you of course.
[Jinsong] I know your concern now -- we can cleanup/simplify xen pad logic by
piggyback on native acpi pad code -- technically it's true. However, we
intentionally do so in order to keep xen pad logic self-contained, just like
what xen mcelog logic did before.
Thanks,
Jinsong--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
