On Sun, Oct 28, 2012 at 06:39:28PM +0100, Oleg Nesterov wrote: > No functional changes. > > powerpc is the only user of arch_uprobe_enable/disable_step() helpers, > but they should die. They can not be used correctly, every arch needs > its own implementation (like x86 does). And they do not really help > even as initial-and-almost-working code, arch_uprobe_*_xol() hooks can > easily use user_enable/disable_single_step() directly. > > Change arch_uprobe_*_step() to do nothing, and convert powerpc to use > ptrace helpers. This is equally wrong, powerpc needs the arch-specific > fixes.
Acked-by: Ananth N Mavinakayanahalli <ana...@in.ibm.com> I will send a powerpc patch to directly use the MSR bits for stepping. Ananth -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/