On 29/10/12 01:28, guanxue...@mprc.pku.edu.cn wrote: >> Including <asm/cacheflush.h> from <asm-generic/io.h> prevents >> cacheflush.h being able to use I/O functions like readl and writel due >> to circular include dependencies. It doesn't appear as if anything from >> cacheflush.h is actually used by the generic io.h, so remove the >> include. >> >> I've compile tested a defconfig compilation of blackfin, openrisc (which >> needed <asm/pgtable.h> including from it's <asm/io.h> to get the PAGE_* >> definitions), and xtensa. >> >> Other architectures which use asm-generic/io.h are score and unicore32, >> and looking at their io.h I don't see any obvious problems. >> >> Signed-off-by: James Hogan <james.ho...@imgtec.com> >> Cc: Arnd Bergmann <a...@arndb.de> >> Cc: Jonas Bonn <jo...@southpole.se> >> Cc: Chris Zankel <ch...@zankel.net> >> Cc: Max Filippov <jcmvb...@gmail.com> >> Cc: Mike Frysinger <vap...@gentoo.org> >> Cc: Chen Liqin <liqin.c...@sunplusct.com> >> Cc: Lennox Wu <lennox...@gmail.com> >> Cc: Guan Xuetao <g...@mprc.pku.edu.cn> > > Acked-by: Guan Xuetao <g...@mprc.pku.edu.cn>
Thanks Guan Cheers James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
