On 10/26/2012 03:37 PM, Michal Hocko wrote: > The root cgroup cannot be destroyed so we never hit it down the > mem_cgroup_pre_destroy path and mem_cgroup_force_empty_write shouldn't > even try to do anything if called for the root. > > This means that mem_cgroup_move_parent doesn't have to bother with the > root cgroup and it can assume it can always move charges upwards. > > Signed-off-by: Michal Hocko <[email protected]> > Reviewed-by: Tejun Heo <[email protected]>
I think it would be safer to have this folded in the last patch, to avoid a weird intermediate state (specially for force_empty). Being a single statement, it doesn't confuse review so much. However, this is also pretty much just a nitpick, do as you prefer. Reviewed-by: Glauber Costa <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
