Some driver uses tasklet_disable in device remove/release process,
tasklet_disable will inc tasklet->count and return. If the tasklet
is not handled yet under some softirq pressure, the tasklet will be
placed on the tasklet_vec, never have a chance to be excuted. This might
lead to a heavy loaded ksoftirqd, wakeup with pending_softirq, but
tasklet is disabled. tasklet_kill should be used in this case.

Signed-off-by: Xiaotian Feng <dannyf...@tencent.com>
Cc: Hansjoerg Lipp <hjl...@web.de>
Cc: Tilman Schmidt <til...@imap.cc>
Cc: Karsten Keil <i...@linux-pingi.de>
Cc: gigaset307x-com...@lists.sourceforge.net 
---
 drivers/isdn/gigaset/interface.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/isdn/gigaset/interface.c b/drivers/isdn/gigaset/interface.c
index 67abf3f..284c7f3 100644
--- a/drivers/isdn/gigaset/interface.c
+++ b/drivers/isdn/gigaset/interface.c
@@ -544,7 +544,6 @@ void gigaset_if_free(struct cardstate *cs)
        if (!drv->have_tty)
                return;
 
-       tasklet_disable(&cs->if_wake_tasklet);
        tasklet_kill(&cs->if_wake_tasklet);
        cs->tty_dev = NULL;
        tty_unregister_device(drv->tty, cs->minor_index);
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to