(2012/11/15 11:54), Glauber Costa wrote: > The original reason for the existence of this test, was that > memcg_kmem_cache_create could be called from either softirq context > (where memcg_stop/resume_account is not needed), or process context, > (where memcg_stop/resume_account is needed). Just skipping it > in-function was the cleanest way to merge both behaviors. The reason for > that is that we would try to create caches right away through > memcg_kmem_cache_create if the context would allow us to. > > However, the final version of the code that merged did not have this > behavior and we always queue up new cache creation. Thus, instead of a > comment explaining why current->mm test is needed, my proposal in this > patch is to remove memcg_stop/resume_account from the worker thread and > make sure all callers have a valid mm context. > > Signed-off-by: Glauber Costa <[email protected]> > CC: Michal Hocko <[email protected]> > CC: Kamezawa Hiroyuki <[email protected]> > CC: Johannes Weiner <[email protected]> > CC: Andrew Morton <[email protected]>
seems ok to me. But do we need VM_BUG_ON() ? It seems functions called under memcg_stop_kmem_account() doesn't access current->mm... Anyway. Reviewed-by: KAMEZAWA Hiroyuki <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
