Hi Mika,
On Fri, 16 Nov 2012 17:23:32 +0200, Mika Westerberg wrote:
> Here's the updated version where we handle 10-bit addresses properly
> (hopefully).
> (...)
> +static int acpi_i2c_find_device(struct device *dev, acpi_handle *handle)
> +{
> (...)
> + memset(&i2c_find, 0, sizeof(i2c_find));
> + i2c_find.addr = client->addr;
> + if (client->flags & I2C_CLIENT_TEN)
> + i2c_find.access_mode = ACPI_I2C_10BIT_MODE;
This works because you are lucky and ACPI_I2C_7BIT_MODE has value 0,
but for correctness I'd rather add:
else
i2c_find.access_mode = ACPI_I2C_7BIT_MODE;
Other than this the new code looks OK WRT this issue, thanks.
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
