On 11/27/2012 11:03 PM, Dan Carpenter wrote: > No need to memset() this when we just copy over it on the next line. > > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> > > diff --git a/drivers/scsi/csiostor/csio_lnode.c > b/drivers/scsi/csiostor/csio_lnode.c > index 551959e..8b54976 100644 > --- a/drivers/scsi/csiostor/csio_lnode.c > +++ b/drivers/scsi/csiostor/csio_lnode.c > @@ -245,7 +245,6 @@ csio_append_attrib(uint8_t **ptr, uint16_t type, uint8_t > *val, uint16_t len) > len += 4; /* includes attribute type and length */ > len = (len + 3) & ~3; /* should be multiple of 4 bytes */ > ae->len = htons(len); > - memset(ae->value, 0, len - 4); > memcpy(ae->value, val, len); > *ptr += len; > } >
Acked-by: Naresh Kumar Inna <nar...@chelsio.com> Thanks, Naresh. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/