On Fri, 30 Nov 2012 06:52:09 -0800 Joe Perches <[email protected]> wrote:
> On Fri, 2012-11-30 at 06:49 -0500, Jeff Layton wrote: > > On Thu, 29 Nov 2012 11:37:19 -0800 > > Joe Perches <[email protected]> wrote: > > > > > Make the compilation work again when CIFS_DEBUG is not #define'd. > > > > > > Add format and argument verification for the various macros when > > > CIFS_DEBUG is not #define'd. > [] > > Would it be better to simply make those the standard > > > > "do { ; } while(0)" noop macros? > > > > I'm not sure I see the point in keeping the printk statements in there... > > Actually, that's not standard. > Look at printk.h > > It prevents developers from adding code that compiles > without warnings in one mode but compiles with warnings > in another. > > The idea is to make sure that format and arguments always > match regardless of whether or not you are compiling > debug or non-debug. > > Fair enough then... Reviewed-by: Jeff Layton <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
