I don't mind removing cEVENT (it is currently unused, and presumably
the older file systems that used EVENT logging, have moved to dtrace
or other tracing mechanisms).
But ... the need still remains for more tracing for cifs (I run into
this a few times a month at least when debugging) - does anyone have
any ideas for how to add dynamic trace points to cifs (has anyone even
done it for the vfs?) - is there any file system that does a good job
defining dynamic trace points?
On Fri, Nov 30, 2012 at 5:47 AM, Jeff Layton <jlay...@redhat.com> wrote:
> On Thu, 29 Nov 2012 11:37:18 -0800
> Joe Perches <j...@perches.com> wrote:
>
>> It uses an undefined KERN_EVENT and is itself unused.
>>
>> Signed-off-by: Joe Perches <j...@perches.com>
>> ---
>> fs/cifs/cifs_debug.h | 7 -------
>> 1 files changed, 0 insertions(+), 7 deletions(-)
>>
>> diff --git a/fs/cifs/cifs_debug.h b/fs/cifs/cifs_debug.h
>> index c0c68bb..b0fc344 100644
>> --- a/fs/cifs/cifs_debug.h
>> +++ b/fs/cifs/cifs_debug.h
>> @@ -63,12 +63,6 @@ do { \
>> /* debug event message: */
>> extern int cifsERROR;
>>
>> -#define cEVENT(fmt, arg...) \
>> -do { \
>> - if (cifsERROR) \
>> - printk(KERN_EVENT "%s: " fmt "\n", __FILE__, ##arg); \
>> -} while (0)
>> -
>> /* error event message: e.g., i/o error */
>> #define cifserror(fmt, arg...) \
>> do { \
>> @@ -88,7 +82,6 @@ do { \
>> */
>> #else /* _CIFS_DEBUG */
>> #define cERROR(set, fmt, arg...)
>> -#define cEVENT(fmt, arg...)
>> #define cFYI(set, fmt, arg...)
>> #define cifserror(fmt, arg...)
>> #endif /* _CIFS_DEBUG */
>
> Yay! More cruft removal!
>
> Reviewed-by: Jeff Layton <jlay...@redhat.com>
--
Thanks,
Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
