On Mon, 2013-01-07 at 09:50 +0800, Wenyou Yang wrote: > To meet the different spi IP version of atmel SoC, > add more compatible "atmel,at91rm9200-spi", "atmel,at91sam9260-spi" > "atmel,at91sam9g45-spi", "atmel,at91sam9x5-spi" with different > config and devtype.
trivial comment: > diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c [] > @@ -230,11 +302,15 @@ struct atmel_spi_device { > * register, but I haven't checked that it exists on all chips, and > * this is cheaper anyway. > */ > -static bool atmel_spi_is_v2(void) > +static bool atmel_spi_is_v2(struct atmel_spi *as) There's a comment that needs updating above this now > { > - return !cpu_is_at91rm9200(); > + if (as->pdata->version == 2) > + return true; > + else > + return false; return as->pdata->version == 2; is rather more readable to me -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/