atmel_spi: add dmaengine support

Yang, Wenyou Mon, 07 Jan 2013 17:03:09 -0800


> -----Original Message-----
> From: Joe Perches [mailto:[email protected]]
> Sent: 2013年1月7日 10:10
> To: Yang, Wenyou
> Cc: [email protected]; [email protected]; Ferre,
> Nicolas; [email protected]; [email protected]; Lin, JM;
> [email protected]; [email protected]
> Subject: Re: [v3 PATCH 06/12] spi/atmel_spi: add dmaengine support
> 
> On Mon, 2013-01-07 at 09:50 +0800, Wenyou Yang wrote:
> > From: Nicolas Ferre <[email protected]>
> []
> > diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> []
> > +static inline bool atmel_spi_use_dma(struct atmel_spi *as,
> > +                           struct spi_transfer *xfer)
> > +{
> > +   if ((as->use_dma) && (xfer->len >= DMA_MIN_BYTES))
> > +           return true;
> > +   else
> > +           return false;
> > +}
> 
> Same unnecessary form.
> 
>       return as->use_dma && xfer->len >= DMA_MIN_BYTES;
> 
> > +static inline bool atmel_spi_use_pdc(struct atmel_spi *as)
> > +{
> > +   if (as->use_pdc)
> > +           return true;
> > +   else
> > +           return false;
> > +}
> 
> Does this function really need to exist at all?
> 
Thanks a lot for your advice.

RE: [v3 PATCH 06/12] spi/atmel_spi: add dmaengine support

Reply via email to